momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-10177: fix: updated tab panel id to be unique #1541

Closed niti-owner closed 8 months ago

niti-owner commented 8 months ago

Description

Updated the arai-controls and aria-labelledby properties of tab and tab panel

Related Issue

Continuation with PR: https://github.com/momentum-design/momentum-ui/pull/1536/files Story: https://jira-eng-sjc12.cisco.com/jira/browse/CX-10177

Motivation and Context

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls

How Has This Been Tested?

Screenshots:

Before (If applicable): image

After:

Screenshot 2024-02-15 at 3 38 31 PM

Types of changes

Checklist:

Recording:

https://github.com/momentum-design/momentum-ui/assets/41052645/8cbb9ea0-8ec9-4904-85ca-778997e025dd

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87d29f1) 94.00% compared to head (7ddae80) 94.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1541 +/- ## ========================================== + Coverage 94.00% 94.07% +0.06% ========================================== Files 134 134 Lines 18990 18990 Branches 2899 2906 +7 ========================================== + Hits 17851 17864 +13 + Misses 1139 1126 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.