momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

CX-10234 - Updated ariaExpanded property for undefined scenarios. #1542

Closed akshatatray closed 8 months ago

akshatatray commented 8 months ago

Description

Buttons announced as "...collapsed" because edge case of empty string was not handled. Resolved ariaExpanded property for empty string cases.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6908576) 94.05% compared to head (ff40a96) 94.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1542 +/- ## ========================================== - Coverage 94.05% 94.03% -0.03% ========================================== Files 134 134 Lines 19016 19016 Branches 2905 2905 ========================================== - Hits 17886 17882 -4 - Misses 1130 1134 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

niti-owner commented 8 months ago

Can you update the PR description with all the details which are applicable?