momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#feat: added arai label and role property for link component #1551

Closed niti-owner closed 7 months ago

niti-owner commented 7 months ago

Description

Added aria label and role property for md-link component

Related Issue

Story: https://jira-eng-sjc12.cisco.com/jira/browse/CX-10268

Motivation and Context

1) md-link only reads the text and does not provide any aria label if more description is required 2) Some places the role needs to be button, hence added new property to accept role

How Has This Been Tested?

1) Tested using Mac VoiceOver 2) Tested using JAWS 3) Added UTs 4) Tested story book

Screenshots:

After: Screenshot 2024-02-27 at 11 56 01 AM

Screenshot 2024-02-27 at 11 22 27 AM

Video https://app.vidcast.io/share/4bcaef25-8e93-4be7-a252-7b16a9a072c3

Coverage Screenshot 2024-02-27 at 11 37 47 AM

Types of changes

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.21%. Comparing base (c2a4657) to head (987e3f4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1551 +/- ## ========================================== + Coverage 94.09% 94.21% +0.12% ========================================== Files 134 134 Lines 19037 19043 +6 Branches 2912 2920 +8 ========================================== + Hits 17912 17941 +29 + Misses 1125 1102 -23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.