momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

feat: Renamed role to ariaRole property #1557

Closed niti-owner closed 7 months ago

niti-owner commented 7 months ago

Description

Renamed role to ariaRole attribute to avoid conflict of attribute names

Related Issue

https://github.com/momentum-design/momentum-ui/pull/1551

Motivation and Context

In react based component, the property can not be passed with dot notaion. To avoid the conflict, renamed the role to ariaRole

How Has This Been Tested?

  1. Updated UTs
  2. Updated story book
  3. JAWs will read out twice if the role is in parent and child both, hence fixed by renaming it to ariaRole.

Screenshots:

Before (If applicable): 308059913-33d0d8ef-180b-449b-b458-fcda20a3ea04

After: Screenshot 2024-03-04 at 5 09 23 PM

Types of changes

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.16%. Comparing base (857a861) to head (234cb9b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1557 +/- ## ========================================== - Coverage 94.16% 94.16% -0.01% ========================================== Files 134 134 Lines 19055 19066 +11 Branches 2926 2919 -7 ========================================== + Hits 17944 17953 +9 - Misses 1111 1113 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.