momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

fix: added id for modal header #1569

Closed niti-owner closed 7 months ago

niti-owner commented 7 months ago

Description

Added id for modal header

Related Issue

CX-10496: Transfer Request dialog is announced with incorrect label

Motivation and Context

By adding id field, the aria-labelledby will be used to announce the dialogue header

How Has This Been Tested?

  1. Tested in Jaws, announcing the header on open
  2. Mac Voice Over - known issue of dialogue not announcing the header

Screenshots:

Before: Refer the jira for video

After: https://app.vidcast.io/share/e7dd4b3d-4c1b-4a0c-9751-29446cc791e3

Types of changes

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.23%. Comparing base (7862c52) to head (dc0bf71).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1569 +/- ## ========================================== + Coverage 94.13% 94.23% +0.09% ========================================== Files 134 134 Lines 19104 19104 Branches 2930 2932 +2 ========================================== + Hits 17984 18003 +19 + Misses 1120 1101 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.