momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

fix(cx-10583): remove unwanted attributes from element #1580

Closed neelabhnagaich closed 6 months ago

neelabhnagaich commented 6 months ago

As buttons, input and anchor already have tabindex of 0 and are by default included in keyboard tab navigation so removing explicit tabindex=0 from them and for buttons we are removing explicit attribute of role=button

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.18%. Comparing base (b9e9ae7) to head (f2c25d6).

Files Patch % Lines
web-components/src/components/button/Button.ts 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1580 +/- ## ========================================== - Coverage 94.20% 94.18% -0.03% ========================================== Files 134 134 Lines 19134 19134 Branches 2940 2946 +6 ========================================== - Hits 18026 18021 -5 - Misses 1108 1113 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

neelabhnagaich commented 6 months ago

BUILD