momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-10208 : Global: Chrome + JAWS: Incorrect heading structure in the notifications dialog #1642

Closed nithishkumar98 closed 4 months ago

nithishkumar98 commented 4 months ago

Description

Removing aria-label since the content and aria-label is same, when without aria-label content will get announced by SR

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.24%. Comparing base (b73c360) to head (b971a5b). Report is 253 commits behind head on master.

:exclamation: Current head b971a5b differs from pull request most recent head 7489d0d

Please upload reports for the commit 7489d0d to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1642 +/- ## ========================================== + Coverage 94.02% 94.24% +0.21% ========================================== Files 132 134 +2 Lines 18176 19280 +1104 Branches 2769 2983 +214 ========================================== + Hits 17090 18170 +1080 - Misses 1086 1110 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.