momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-13613 : Web - Change State: Screen Readers: Unnecessary and verbose announcement for the opened dialog #1659

Closed nithishkumar98 closed 4 months ago

nithishkumar98 commented 4 months ago

Description

added aria-hidden for the icons and removed title

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.46%. Comparing base (b73c360) to head (e4e4cd4). Report is 267 commits behind head on master.

:exclamation: Current head e4e4cd4 differs from pull request most recent head 6a2bd02

Please upload reports for the commit 6a2bd02 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1659 +/- ## ========================================== + Coverage 94.02% 94.46% +0.44% ========================================== Files 132 134 +2 Lines 18176 19394 +1218 Branches 2769 3025 +256 ========================================== + Hits 17090 18321 +1231 + Misses 1086 1073 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.