fix: cx-15081: issue with tab list component - Githubissues

momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.

https://momentum.design

MIT License

199 stars 204 forks source link

fix: cx-15081: issue with tab list component #1665

Closed DeboTest closed 4 months ago

DeboTest commented 4 months ago

Description

CX-15081

Related Issue

Motivation and Context

Issue:

Press Enter to open the More Tabs option
Select any Tab other than first option and use escape key to close the More Tabs
Again open - It will always show the first Tab as active Tab

Fix:

If More Tab menu has no previously selected option select first option (this is the case when we first open More Tab menu)
Else select previously select option

How Has This Been Tested?

Test should handle Enter Press keydown event with More Button and focus appropriate tab added to Tabs.test.js

Screenshots:

Before (If applicable): Screen Recording 2024-06-17 at 18 10 04

After: Screen Recording 2024-06-17 at 18 06 24

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.69%. Comparing base (b1af515) to head (736dfdd).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1665 +/- ## ========================================== + Coverage 94.56% 94.69% +0.12% ========================================== Files 134 134 Lines 19423 19422 -1 Branches 3033 3040 +7 ========================================== + Hits 18368 18392 +24 + Misses 1055 1030 -25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.