fix(build): build warning of scss declaration - Githubissues

momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.

https://momentum.design

MIT License

199 stars 204 forks source link

fix(build): build warning of scss declaration #1713

Closed Jason20020 closed 2 months ago

Jason20020 commented 2 months ago

Description

Fix the warning of scss's behavior for declarations that appear after nested rules. Two way on fixing:

Move the declaration above the nested rule
Wrap declaration in &{}

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.