momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

Fix virtual tooltip changeMessge handler not checking reference #1803

Closed stefanbalmus closed 4 days ago

stefanbalmus commented 5 days ago

Description

This fixes a bug in Theme.ts which leads to md-tooltip components showing the wrong tooltip. The issue can be observed in several ways but one example is:

Related Issue

Motivation and Context

How Has This Been Tested?

To reproduce the issue easier, I've added a delay (during development testing) in AudioPlayer.ts inside the firstUpdated so that the audio source is updated with a delay. This is to allow enough time for the original tooltip to display, before the audio is loaded. Then followed the steps described above.

Screenshots:

Before (If applicable):

tooltip_pr_fix_before

After:

tooltip_fix_pr_after

Types of changes

Checklist: