search

momentum-mod / game

Momentum Mod - Standalone Source Movement Speedrunning (READ README)
https://momentum-mod.org
Other
520 stars 209 forks source link

Investigate removing any potential command rate-limiting #1615

Open hexaflexahexagon opened 2 years ago

hexaflexahexagon commented 2 years ago

Other source games like csgo or tf2 have rate limits on commands that can be done at once (like exec'ing a .cfg file for example) to avoid server abuse. We should look at removing these wherever relevant as a low priority QoL feature.

Relevant discord conversation: https://discord.com/channels/235111289435717633/356398721790902274/920093600149299200

itVictor commented 2 years ago

Should this actually be considered? I'm pretty sure you could use this to do freeze glitching in tf2 before they added the spam protection.

hexaflexahexagon commented 2 years ago

everything in momentum is client-side so freezeglitching is useless (the server freezes, not just the client like in tf2 before the patch). not to mention there are infinite ways of generating lag, this is just one.

Gocnak commented 2 years ago

I need concrete examples that we would need to remedy. I don't agree with outright removing rate limits. We can increase them instead for specific things?

hexaflexahexagon commented 2 years ago

In this case the concrete example would be what Mac did in that discord conversation.

  1. Make potato.cfg file with tons of graphics-related commands
  2. Try to exec potato
  3. Game says you're issuing too many commands at once

Whatever the rate limit is may not need to be literally removed, but raised enough to make something like the above work as intended. I don't know what the reasoning valve had for adding this limit was so if it's super essential maybe we'd be better off buffering commands if somebody drops 300 all at once? Or just raising it to whatever limits seem sane. I would assume this limit exists to not flood servers (as Enjoy mentioned in that discord conversation) and if that is the case we don't have a use for it considering the lack of traditional servers.