search

momentum-mod / game

Momentum Mod - Standalone Source Movement Speedrunning (READ README)
https://momentum-mod.org
Other
522 stars 208 forks source link

Additional Run Safegaurds #1643

Open ProgrammingPaddy opened 2 years ago

ProgrammingPaddy commented 2 years ago

What feature is your improvement idea related to?

Currently there are the options of "None" "When No Movement Keys Held" and "On Double Press Only" for run safeguards.

Describe the solution you'd like

An additional option "While Timer is Not Running" that simply does not allow an action with the safeguard on to be performed if the player has their timer running.

Describe alternatives you've considered, if any.

No response

Additional context

No response

tsa96 commented 2 years ago

Note https://github.com/momentum-mod/game/issues/1364, these should probably be done at the same time, so maybe move to 0.9.3?

tsa96 commented 1 year ago

Confused by this issue. Safeguards are designed to only apply to when you have a timer running. What is the point of it?

We're working on a spec for new safeguard system currently here https://docs.google.com/document/d/197-iXASwnrTrtgq1xaZkqG58n-wBt-zvBGe2VU_7PJY/edit?usp=sharing, feel free to comment on the gdoc and upcoming Discord thread

ProgrammingPaddy commented 1 year ago

The idea is there is no override for actions you 100% do not want to occur during the run. For example having a saveloc teleport on alt or tab will get pressed twice, with no movement keys held if someone alt tabs from the game. This bypasses all current safeguard and has resulted in runs being reset. Having an additional option that outright disables the key while the timer is running removes concern for edge cases like this.