search

momentum-mod / game

Momentum Mod - Standalone Source Movement Speedrunning (READ README)
https://momentum-mod.org
Other
531 stars 210 forks source link

$envmap not rendering on material where it should. #2026

Closed granis48 closed 1 month ago

granis48 commented 1 year ago

Describe the bug

If a vmt specifies an $envmapmask texture at the same time as $normalmapalphaenvmapmask 1 it will stop rendering the cubemap reflections altogether.

How To Reproduce

Here is the material this bug was discovered on glass.zip. Seems to happen on every (only tested LightmappedGeneric) material that uses both an envmapmask and the other parameter with it.

Issue Map

Here is the map where this bug was discovered surf_axiom. The glass texture can be found allover the map but here is a comparison: css image momentum image

Expected Behavior

I don't see why anyone would ever use $normalmapalphaenvmapmask 1 when they have an actual envmapmask already specified but since it works in css i expect it to work in momentum mod as well :)

Operating System

win10

granis48 commented 1 year ago

Turns out this is a duplicate issue https://github.com/momentum-mod/game/issues/1268#issuecomment-812737968. I guess we gotta decide if this is worth "fixing" by doing what css does and prioritize one of the parameters, or if we'd rather just fix the material in the maps where it is used as we add those maps to the game.

Gocnak commented 1 month ago

Decided in the other issue, we can use Lumper to fix this in the future as well.