search

momentum-mod / lumper

BSP lump editor and review tool
MIT License
20 stars 13 forks source link

Implement Drag-n'-Drop support #19

Open Riven-Spell opened 1 year ago

Riven-Spell commented 1 year ago

Resolves #18

This is probably on the hacky/bad side, due to my general lack of familiarity with Avalonia-- But, I'm happy to hear any and all feedback, even if it's "Start from scratch and do it this way". I'm here to learn and contribute.

BIRD311 commented 1 year ago

Did unfortunately not work for me on linux (tested i3 and openbox). Maybe you could test this again on you system. The linked issue mentions opening new lumper instanced for multiple files.

Riven-Spell commented 1 year ago

Did unfortunately not work for me on linux (tested i3 and openbox). Maybe you could test this again on you system.

Works fine for me on Windows-- I've yet to try on my Linux install, but I'll get around to it after work today.

The linked issue mentions opening new lumper instanced for multiple files.

I can look into doing this.

Riven-Spell commented 1 year ago

I'll get around to it after work today.

Liar, liar, pants on fire!

Did unfortunately not work for me on linux (tested i3 and openbox). Maybe you could test this again on you system.

https://github.com/AvaloniaUI/Avalonia/issues/6085 Appears to be a known issue. That's fine for now.

The linked issue mentions opening new lumper instanced for multiple files.

Trying to get this working, being a bit finnicky.

It works now. Just a little slow (perhaps the best option will be to delay open until after the new window is open so the user thinks something's happened)

tsa96 commented 1 year ago

Looks good to me! @BIRD311 did you bring up the issue about the file location or whatever you were talking about yesterday?

tsa96 commented 3 weeks ago

This could be picked up again once my PR is in, either by the original author if they're still around, or someone else. But I'd suggest just rewriting / copying stuff over rather than rebasing.

The DataContext shadowing stuff I don't understand, just use ReactiveWindow (might be doing this alrwsy on my PR, don't remember) and WhenActivated. And setting up the event handlers should be done in the view.