momentum-mod / lumper

BSP lump editor and review tool
MIT License
20 stars 13 forks source link

Mounted Asset Removal #3

Open Gocnak opened 1 year ago

Gocnak commented 1 year ago

We actually have a C++ tool shipping with the game that does this: "bspfix.exe"

So ideally all we need to do is invoke it on the bsp here.

tsa96 commented 1 year ago

For clarification, we have bspfix in C++ but want to write a C# version. Rewriting the C++ exactly would require license, but the concept is simple, compare a hash of every file in the Paklump with Valve assets of corresponding file type.

We don't want to require everyone running these checks have all content downloaded, instead we'll ship a JSON file with releases.

We need:

Both should be usable via CLI and UI. It's important we can hook the hash generation up to our internal CI, as well as perform the hash checks via command-line, maaaaaybe integrating into the backend eventually.

tsa96 commented 1 year ago

See https://discord.com/channels/235111289435717633/998769771451519088/1072388945146552370 for discussion of this

BIRD311 commented 1 year ago

Unassigned my self for now in case someone wants to pick this up. Calling bspfix on the map was implemented* but rewriting this in C# was not.