search

momentum-mod / website

Momentum Mod's main website.
https://momentum-mod.org
MIT License
58 stars 60 forks source link

Broken lightbox on recent Ng-gallery version #777

Closed tsa96 closed 6 months ago

tsa96 commented 1 year ago

Just upgraded to new NPM package for https://github.com/MurhafSousli/ngx-gallery (we were waaaaay behind).

Trying to open the lightbox now errors with Error: [NbOverlayContainerAdapter]: Layout not found.. Wrapping the entire app in <nb-layout> does fix it, so we can give that another go once we get rid of the main page (see https://github.com/momentum-mod/website/issues/739 for more on NbOverlay issues).

I don't want to do the triple-wrapped setup now (each time adds 4 layers of junk to the DOM), going to just leave broken until we get rid of the main page. With the rate traz is working on mock-ups currently, we may even have that for 0.10.0!

tsa96 commented 1 year ago

Also, I can't get the fullscreen panelClass stuff to work. withConfig is no longer valid, and global setup here https://github.com/MurhafSousli/ngx-gallery/wiki/Gallery doesn't seem to work, though haven't spent long on it. Once the lightbox is fixed we should also try going back to the fullscreen mode.

tsa96 commented 9 months ago

PrimeNG has a gallery component I'm going to try out in my ongoing PR.

tsa96 commented 7 months ago

https://github.com/momentum-mod/website/pull/906 will close, no longer using this component :)