momentum-mod / website

Momentum Mod's main website.
https://momentum-mod.org
MIT License
58 stars 59 forks source link

Replace Nebular (probably also ngx-pagination and ng-gallery) with PrimeNG #865

Closed tsa96 closed 9 months ago

tsa96 commented 10 months ago

Nebular is barely maintained and has some really horrible design decisions built in (such as <nb-layout> wrapper bullshit). In general, we should rely on libraries like Nebular for general styling less, and just use it for more complex components we don't want to make ourselves.

PrimeNG seems a lot nicer, and is better maintained. Their site claims they'll be shipping a new styling system in "Q3 2023", we don't need to worry about styling until after 0.10.0 though, so don't mind using their dark Material-based theme for now.

Also, we don't gain anything from Nebular's layouting stuff, or the ngx-admin template - in fact I've been removing bits of it constantly over the last few weeks and at this point would be very happy getting rid of it entirely. Doing layouts for sites like our dashboard is not difficult, it's just that the devs working on Momentum circa 2018 didn't have much experience, so wanted something easy to start with. I'm comfortable with Angular at this point, and it's high time we spread our wings and take a less amateur approach to our frontend work.

So, I'm gonna get rid of Nebular entirely, try to use fewer pointless components from component libraries (e.g. nb-card), keeping styling to Tailwind and a single global stylesheet. ngx-pagination and ng-gallery may be okay for now, though when I next touch pages using them I'll try out PrimeNG's equivalents and see if they're any better.