momentum-mod / website

Momentum Mod's main website.
https://momentum-mod.org
MIT License
55 stars 60 forks source link

Revert XP constant changes #885

Closed tsa96 closed 6 months ago

tsa96 commented 6 months ago

Split these changes out from https://github.com/momentum-mod/website/pull/876 so we can review separately. Sorry that it's still on top of all those commits, some file renaming/moving requires it, this branch is really just the last two commits!

So, I completely misunderstood how new user cosmetic XP/level assignment worked, getting the wrong impression that new users were supposed to start at 20,000 XP. This was completely my own fault, I ported some of the initial XP systems code from the old backend wrong, and assumed the weird behaviour was a result of the original design, not my own crappy porting. Apologies for that! This reverts to the original constants, and starts new users with the correct starting values of level 1, 0 XP. I don't test that directly, but hopefully @ianwillis98 or whoever ends up doing https://github.com/momentum-mod/website/issues/868 can do checks in there.

Also, having dug up the original spreadsheet to the cosmetic XP stuff, I wrote some unit tests for those values. Don't worry, the Google sheets URL in the comment is view-only.