Add logic to prevent changing user alias on logout/login

[kanoka42]

Date: Fri May 31 10:58:39 2024 -0500

Implements fix for bug #921

Implements fix for bug #921 which resets the users alias on logou and back in. This fix

• Implements a new regex to disallow purely whitespace based aliases
• E2e testing on the new aliases
• Logic to test if the user name is valid, or is the default value

Closes #921

[kanoka42]

Closes #921

[tsa96]

The commit name doesn't follow our naming conventions, make sure you have commit hooks working (run npm install). Also it worth doing test for the issue itself mentioned in #921, something like "should not update alias when user exists" in auth.e2e-spec.ts

Some existing E2E tests were modified to check this, I think coverage is okay. Have asked for a unit test as well, then I think we're good.

[kanoka42]

The commit name doesn't follow our naming conventions, make sure you have commit hooks working (run npm install). Also it worth doing test for the issue itself mentioned in #921, something like "should not update alias when user exists" in auth.e2e-spec.ts

The tests had to be reworked to account for this specific change, so a few of the tests check for this issue now.

[tsa96]

Woops!