search

momentum-mod / website

Momentum Mod's main website.
https://momentum-mod.org
MIT License
58 stars 59 forks source link

Review comment images downloading rather than opening in new window #983

Closed tsa96 closed 3 weeks ago

tsa96 commented 3 months ago

I know there's some fix for this just don't remember what :)

GordiNoki commented 2 months ago

If you just want to open images in new page you need target="_blank", which we have, and images returning from cdn should have proper image/png content type. Currently they are application/octet-stream

tsa96 commented 2 months ago

Yeah it's just us not setting a ContentType property in the S3 PutObjectCommand call

tsa96 commented 2 months ago

Closed by #999, though my WIP code makes this use my new gallery component anyway.