momentumdevelopment / cosmos

Free, open-source, Minecraft 1.12.2 PvP client aimed at the anarchy community.
GNU General Public License v3.0
153 stars 39 forks source link

Revert event handler back to FML #141

Closed xgraza closed 2 years ago

xgraza commented 2 years ago

So, I got bullied big time for the event system

image

Yes, I could've made it faster but apparently 10-20ms is slow, compared to 1-5ms (obviously)

Until I fix this, I say we revert back to the old event system

Should I care what people say? Probably not, it's a 5ms difference oh well, but if there's one with 1-5ms, it could 100% be faster.

IUDevman commented 2 years ago

Uh you know what milliseconds are bruv?

xgraza commented 2 years ago

Yes, I do. The 5ms example was just a number I threw out there. I also saw your post in the Discord. I was clearly joking when I said that he was bullying me, I was taking the criticism.

xgraza commented 2 years ago

There's really no need to put out there that I thought ~10ms was fast enough. I did get 0ms at times with the event handler, but it wasn't consistent enough to put as the delay, so I put the 10-20ms. It never actually got to 20ms, I was just estimating the time max.

Also, my computer is pretty shit. Not that it has to do with anything.

If it makes you feel any better, I privated the event handler.

IUDevman commented 2 years ago

If it makes you feel any better, I privated the event handler.

Bro lukflug

yagel15637 commented 2 years ago

this issue makes me happy

xgraza commented 2 years ago

If it makes you feel any better, I privated the event handler.

Bro lukflug

What do you mean by this? I'm genuinely confused.

FluorideHistorian commented 2 years ago

i need to know

was that time for a single event