[IMPL] Outline Fill shader + Dotted shader fix

[master7720]

ay wolf can you also fix the build issue too

[surge541]

I believe the build issue is because Linus is rewriting the CA, so where the CA is referenced (i.e. PresenceManager), it is using a variable from the rewrite, however Linus hasn't committed the rewrite so it causes the build to fail. Basically, no, but it will be fixed when Linus commits the new CA. However if you load Cosmos in an ide (e.g. IntelliJ) you can fix it by just changing the line(s) where it references the new CA, then build it.

[master7720]

I believe the build issue is because Linus is rewriting the CA, so where the CA is referenced (i.e. PresenceManager), it is using a variable from the rewrite, however Linus hasn't committed the rewrite so it causes the build to fail. Basically, no, but it will be fixed when Linus commits the new CA. However if you load Cosmos in an ide (e.g. IntelliJ) you can fix it by just changing the line(s) where it references the new CA, then build it.

ok thanks babe

[surge541]

I believe the build issue is because Linus is rewriting the CA, so where the CA is referenced (i.e. PresenceManager), it is using a variable from the rewrite, however Linus hasn't committed the rewrite so it causes the build to fail. Basically, no, but it will be fixed when Linus commits the new CA. However if you load Cosmos in an ide (e.g. IntelliJ) you can fix it by just changing the line(s) where it references the new CA, then build it.

ok thanks babe

np

[master7720]

wait why are you making issues? arnt you a dev for this client you should get access to the repo

[surge541]

wait why are you making issues? arnt you a dev for this client you should get access to the repo

idk I don't really know whether to call myself a dev lmao

[master7720]

wait why are you making issues? arnt you a dev for this client you should get access to the repo

idk I don't really know whether to call myself a dev lmao

you kinda did alot so idk

[surge541]

wait why are you making issues? arnt you a dev for this client you should get access to the repo

idk I don't really know whether to call myself a dev lmao

you kinda did alot so idk

ig but there's also them needing to make sure my code style is correct as well as documented properly

[master7720]

wait why are you making issues? arnt you a dev for this client you should get access to the repo

idk I don't really know whether to call myself a dev lmao

you kinda did alot so idk

ig but there's also them needing to make sure my code style is correct as well as documented properly

ye lol

[master7720]

btw can you add the tab gui

[master7720]

do it like what konas does you have the normal gui module then the TabGUI module

[surge541]

btw can you add the tab gui

@linustouchtips should I?

[master7720]

btw can you add the tab gui

@linustouchtips should I?

its a good idea tbh

[master7720]

you should make it so you can change from the old tab gui to the new tab gui

[surge541]

btw can you add the tab gui

@linustouchtips should I?

its a good idea tbh

Yeah I mean it's not hard, just want to make sure the Linus is ok with it first :P

[master7720]

btw can you add the tab gui

@linustouchtips should I?

its a good idea tbh

Yeah I mean it's not hard, just want to make sure the Linus is ok with it first :P

he will probably be ok with it idk why he will not be ok with it

[master7720]

btw wolf if you have time could you rewrite the ViewModel

[surge541]

yeah maybe current viewmodel is kinda shit (sorry aesthetical)

[master7720]

yeah maybe current viewmodel is kinda shit (sorry aesthetical)

yup it should look like this

https://github.com/DriftyDev/CLEAN_Kami5-1.8-BUILDABLE_SRC/blob/main/src/main/java/tech/mmmax/kami/impl/features/modules/render/ViewModel.java

[surge541]

tabgui has been approved @master7720

[xgraza]

yeah maybe current viewmodel is kinda shit (sorry aesthetical)

i just havent fixed it yet

[xgraza]

i know whats wrong with it, ive just havent touched it in awhile

[master7720]

tabgui has been approved @master7720

YES thank you