search

momi-foundation-coding / nodejs-api-cli

This is a scaffold for generating new API-based application for NodeJS and its frameworks such as Express, kemboijs, koa, AdonisJs etc.
http://www.kemboijs.org/
MIT License
10 stars 13 forks source link

Set up linter for the project using something like prettier #25

Closed ezkemboi closed 4 years ago

ezkemboi commented 5 years ago

Under discussion.

ezkemboi commented 5 years ago

Also, to help us more, we can look at this document and give more suggestions https://eslint.org/docs/rules/

ezkemboi commented 5 years ago

We can also work on commit rules and allow some rules to pass before someone can push. That is, determine the workflow of the application.

its-tayo commented 4 years ago

@ezkemboi for eslint, I think we can use one of the popular configs like Airbnb or Google. For commit rules, we can use commitlint/commitzen for enforcing commit message formats. Apart from commit message formatting, is there any other thing we need to set in commit hooks (like code linting before pushing...)?

ezkemboi commented 4 years ago

I think code linting is before the commit hooks. Let's make use of Airbnb

its-tayo commented 4 years ago

Hi @ezkemboi, I just finished setting up eslint and prettier, should I go ahead with fixing all issues as well or leave that to you?

its-tayo commented 4 years ago

Hi @ezkemboi, I just finished setting up eslint and prettier, should I go ahead with fixing all issues as well or leave that to you?

Hi @ezkemboi, waiting for your take on this.

ezkemboi commented 4 years ago

@its-tayo go ahead fixing the issues bro. I am expecting to review some of the work tonight and tomorrow and merge. You can take any issue and raise a PR.

ezkemboi commented 4 years ago

@its-tayo take this one and just let me know when you have raised a PR.

its-tayo commented 4 years ago

@ezkemboi no worries, will do so.