search

momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.
Mozilla Public License 2.0
99 stars 26 forks source link

Fix merge #107

Closed acestronautical closed 3 months ago

acestronautical commented 3 months ago

Fix merging to use copypages instead of embedPDF. This resolves a margin issue where margins were being used from the source and destination PDFs in a weird way.

Replace hopding/pdf-lib with the maintained cantoo-scribe/pdf-lib to which we have an upstreamed performance fix for copypages https://github.com/cantoo-scribe/pdf-lib/pull/48

Perform an npm audit fix and npm update

improve upload performance by pulling some variables out of the page rotation loop

momijizukamori commented 3 months ago

Can you do a quick filesize check? I feel like copyPages had more overhead and that's why I changed it....

acestronautical commented 3 months ago

Not sure why the import is failing after switching to the cantoo version? It works fine on my local hosted version? Edit: import was failing because I had the name wrong lol

File size seems the same for me, but I'm using a mostly text PDF

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-03-09 04:55 UTC