search

momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.
Mozilla Public License 2.0
99 stars 26 forks source link

initial stab & functionality of spine marks #109

Closed sithel closed 1 month ago

sithel commented 3 months ago

Spinelines! ✨

Octopus | Little Cat Press on the main discord tested it out and gave it a 👍 I vetted the output PDF and those marks are in the center but fuck me- they don't print like it! Printed a funking chonker only to find out they were slightly off-center in output.... Still workable though and very helpful! Need to add an adjustment field to help with that, but that's for later UI/UX

Screen Shot 2024-04-11 at 9 16 41 PM

I am still VERY cranky about being told I couldn't add a "full preview" checkbox to the page. Really... quite upset about that... but I left it off and added in fullPreviewDevHack to createoutputfiles in book.js

first half of thoughts/process written up here -- of course I dove back in today and found a number of issues/incorrect assumptions that I may or may not go back and document 😩

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-05-07 16:13 UTC

momijizukamori commented 1 month ago

Can you update the version number on this? Forgot to check on the other request for that, but they cover some of the same stuff anyway, lol

sithel commented 1 month ago

version bump bumped

momijizukamori commented 1 month ago

Go ahead and merge this once that dev flag is switched, everything else looks good.

sithel commented 1 month ago

turned off dev flag (good catch!) but need a ✅ before I can merge