search

momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.
Mozilla Public License 2.0
99 stars 26 forks source link

Fixed folio duplexrotate - but at what cost... #111

Open momijizukamori opened 3 months ago

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://momijizukamori.github.io/bookbinder-js/pr-preview/pr-111/ on branch gh-pages at 2024-03-13 00:33 UTC

acestronautical commented 3 months ago

Code looks reasonable, not sure I love the naming. ‘Alt’ is pretty generic and I think we use it elsewhere to maybe mean something else?

momijizukamori commented 3 months ago

Code looks reasonable, not sure I love the naming. ‘Alt’ is pretty generic and I think we use it elsewhere to maybe mean something else?

I think the one spot we use it was left over from my initial pass at trying to get folio working (like two years ago), but I will go back through.

sithel commented 3 months ago

am too fried to review this tonight, sorry. Will pass on though that nonbinary_octopus (who had asked about it this afternoon) tested it and 👍 (which is mostly what I care about) -- will ask for version number bump for this this once url changes land

acestronautical commented 3 months ago

Do we need to remove the 'NOTE: Not currently working for folios, sorry! Use the old version for now.' text from html?