search

momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.
Mozilla Public License 2.0
99 stars 26 forks source link

Setup for PDF tests #116

Closed momijizukamori closed 1 week ago

momijizukamori commented 1 month ago

No actual PDF testing yet, but this has the package changes, and also a bunch of moving parts of book.js into separate functions so it's possible to test without having to do absolutely crazy monkeypatching.

There should be no actual functionality changes, but given the amount of async/await we have, I'd like a second set of eyes on it.

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-17 19:14 UTC

acestronautical commented 1 month ago

I like these changes, I think that pulling things out into smaller functions like this improves the self documenting of the code. I do see what appears to be a bug in the preview this.createSignatures is not a function? Do you see this same issue? Haven't taken an in-depth look but maybe the scope of 'this' changed?

momijizukamori commented 1 month ago

I like these changes, I think that pulling things out into smaller functions like this improves the self documenting of the code. I do see what appears to be a bug in the preview this.createSignatures is not a function? Do you see this same issue? Haven't taken an in-depth look but maybe the scope of 'this' changed?

Oh, hah, that's the same issue I had with six's dev preview flag. I'll have a look - probably some of the locally scoped functions need to be moved up to the class level.