Feature: Advanced control over scale and margin options

momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.

Mozilla Public License 2.0

100 stars 26 forks source link

Feature: Advanced control over scale and margin options #12

Closed momijizukamori closed 6 months ago

momijizukamori commented 2 years ago

Give people options for how to place pages from the doc onto sheets, particularly when the doc page size does not match the sheet page size - for example, to split the difference in margins evenly between sides, or to put it all to one side or the other. Ideally with a nice little visual diagram to show what's happening!

sithel commented 2 years ago

Yoooooooo! I'm actively working on this right now. Hope to have a PR up.... tomorrow? Please let me know if I'm missing anything, but so far I've broken it down into:

scale: 'keep proportional' / 'stretch' / 'original'
positioning: 'centered' / 'snug against binding' And I'm adding the option to manually pad top/bottom/fore edge/binding sides with specified white space (in points to start with) If you've got other suggestions (relative to this stuff) while I'm in the code, am happy to try and tackle 'em... let me know?

(ugly UI so far, will fix before posting)

sithel commented 2 years ago

"Hope to have a PR up.... tomorrow?" she said, full of vanity and terrible time estimates.... meh, at least I got it within the week?

sithel commented 1 year ago

Basic functionality is there-- UI is hacky though and some folks wanted pts defined in CM as well-- leaving ticket open because cleanup of that UX could be done (let user specify unit?)

Lottie16 commented 6 months ago

@sithel is this issue finished? The pr is merged

sithel commented 6 months ago

I guess now it is 🤷‍♀️