momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.
Mozilla Public License 2.0
139 stars 31 forks source link

Page Scaling #18

Closed sithel closed 2 years ago

sithel commented 2 years ago

Related to Issue #12

What this PR includes:

Not covered in this PR:

I'm going to do another pass of testing tomorrow, want to post this and get first impressions/review my own stuff... Do not feel like writing tests for this... sorry πŸ˜“ I will, tomorrow, list out some key manual tests and verify them, flexing the different combo of settings. Will probably enumerate list of manual tests that are good to run on README....

Ugly new UX :

Screen Shot 2022-06-26 at 11 50 13 PM

Am open to suggestions on how to format that better-- are you ok if I solicit the discord for UX suggestions/guidance?

sithel commented 2 years ago

am not properly/consistently using the phrases "padding" or "margin" -- what should I call this gap? (I think "padding" is what I settled on in code?)

momijizukamori commented 2 years ago

if you resolve the merge conflicts, this will be good to go I think.

sithel commented 2 years ago

Appreciate approval! πŸ™ Am still going to go through and do an audit/screenshot of the 3 different docs in the various layouts before landing. (especially since I just found a bug doing so)