Re-doing PDF positioning logic & adding preview to PDF in Cell placement - Githubissues

momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.

Mozilla Public License 2.0

139 stars 31 forks source link

Re-doing PDF positioning logic & adding preview to PDF in Cell placement #55

Closed sithel closed 10 months ago

sithel commented 1 year ago

This PR is to help users better understand how their page is going to be laid out, before we even hit the Preview of PDF step. There's now an info section that pops up & updates with the form showing how a PDF page will be positioned & scaled within a layout cell. Also audited/corrected page positioning/scaling/margin behavior. (related to #53 ) Link to test our PR

This only (currently) effects/works with the "Classic" layouts

Changes:

bumped version to 1.1.0
added preview to the Page Layout section
corrected margin & page positioning behavior

Examples

Basic Octavo layout Screen Shot 2023-09-20 at 4 02 59 PM Screen Shot 2023-09-20 at 4 12 58 PM

Square Sexto, against the spine with margin on bottom Screen Shot 2023-09-20 at 4 17 39 PM

Square Sexto, centered with margin on top

Screen Shot 2023-09-20 at 4 18 28 PM

sithel commented 11 months ago

@momijizukamori - have addressed what you pointed out 👍 (am assuming I should hold for Approval before just landing PR)

sithel commented 10 months ago

received in-Discord chat approval by Cocoa last night for this