momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.
Mozilla Public License 2.0
99 stars 26 forks source link

Centralize configuration and store all inputs in local storage and the uri #63

Closed cass-kazumori closed 5 months ago

cass-kazumori commented 6 months ago

Fixes #44 Fixes #47

This:

If we were to want to add a new input or configuration, the proposed process would look similar to the following:

Ideally, I'd like to automate the last two – but this is a start.

sithel commented 6 months ago

Am getting an error on the console if I select a Wacky layout -> reload page -> upload PDF -> select Standard Signatures

to be fair tho-- I get a (different) error in the console when going through this this flow on released/current version as well

cass-kazumori commented 6 months ago

The issue with the custom dimensions should be fixed now. We may want to clean up some of our handling around the inclusion (or exclusion) of the custom page size option, and how we track and append that to the page size list. Namely, so that we don't need to manage in several places the handful of (order dependent) calls to pull that option into the list, and when we set it. It's not a big deal or anything, but I wouldn't mind cleaning it up a bit.

@momijizukamori I also added the booklet option to the configuration set for our signature formats. You may just make sure that I didn't mess anything up when resolving out the merge conflicts. I don't believe that I did, but a second pair of eyes never hurt anyone.