search

momijizukamori / bookbinder-js

A JS application to format PDFs for bookbinding.
Mozilla Public License 2.0
99 stars 26 forks source link

Spine Lines: Take 2! #77

Closed sithel closed 4 months ago

sithel commented 4 months ago

Adds option to draw marks on the outermost folio of each signature at the top & bottom of the PDF, as it's positioned on the page.

This is useful for people adding padding via the Imposer This is also the groundwork for adding signature ordering marks (will add in followup PR, will be much easier after this)

New enabling UI

Screen Shot 2024-02-03 at 12 06 15 AM

Samples of what they look like on the docs:

Screen Shot 2024-02-03 at 12 05 31 AM Screen Shot 2024-02-03 at 12 05 11 AM Screen Shot 2024-02-03 at 12 04 54 AM Screen Shot 2024-02-03 at 12 04 33 AM
momijizukamori commented 4 months ago

Also could you have a look at the failing unit tests?

github-actions[bot] commented 4 months ago

PR Preview Action v1.4.6 :---: :rocket: Deployed preview to https://momijizukamori.github.io/bookbinder-js/pr-preview/pr-77/ on branch gh-pages at 2024-02-05 03:54 UTC

acestronautical commented 4 months ago

I tested it in the PR preview and it seems to work correctly :)