search

mominsamir / smDateTimeRangePicker

Angular Material Date Picker, DateTime Picker, Date Range Picker, Date Time range picker
http://mominsamir.github.io/smDateTimeRangePicker/
MIT License
130 stars 50 forks source link

The value of onRangeSelect callback should return moment objects #100

Closed oscar09 closed 7 years ago

oscar09 commented 7 years ago

onRangeSelect callback returns the date as strings. It would be useful to return them as moment objects as well. See #93.

oscar09 commented 7 years ago

Moment object are returned on the properties "startDateAsMoment" and "endDateAsMoment". Documentation was updated as well.

pablorsk commented 7 years ago

@oscar09 what is the npm version?

oscar09 commented 7 years ago

on my machine? 3.5.2

pablorsk commented 7 years ago

sorry, I ask about publish this library.

you can do npm publish or can do only @mominsamir?

oscar09 commented 7 years ago

The change is already merged. Pull request #103 and commit #618b665dd0c66fa711a1c54aa0ff50d58fab68ac

oscar09 commented 7 years ago

I did not run npm publish nor created a different tag because I am not sure if tags are created when several features/bugs have been fixed and tested.

mominsamir commented 7 years ago

you can create new tag if this is bug fix to x.x.7 from earlier version x.x.6 for some major enhancement create tag to x.1.x from current x.0.x. last for breaking changes update entire version to 3.x.x from 2.x.x

push new tag as per ur changes and i will publish on npm

oscar09 commented 7 years ago

Tag v2.0.7 was created. I just noticed you also have a "develop" branch. Shall we keep adding changes on the master branch or the develop branch?

mominsamir commented 7 years ago

This version can not be publish as you missed to update package.json file. only if version is matching to package json npm publish can be run.

You may create your own branches for development and later merge it with master branch (this way is better, less conflicts ), or you can work on master branch it self (more conflicts).

{ "name": "smdatetimerangepicker", "version": "2.0.7", "description": "angular material Date Time Range Picker",

oscar09 commented 7 years ago

I missed that, I will update the file.

mominsamir commented 7 years ago

it can be publish with old version tag please update with tag 2.0.8

oscar09 commented 7 years ago

done

mominsamir commented 7 years ago

published with npm