NOTALFOSC parameter updates

mommermi / photometrypipeline

automated photometry pipeline for small to medium-sized observatories

GNU General Public License v3.0

62 stars 26 forks source link

NOTALFOSC parameter updates #47

Closed Siltala closed 4 years ago

Siltala commented 4 years ago

Hi, This PR adds correct filter translations for the UBVRI filters for the NOT. In addition, the (previously incorrect) observatory code is fixed.

I also note that ALFOSC/FASU has multiple filter wheels, each with its own individual keyword. The UBVRI filters are always in ALFLTNM (which telescopes.py currently checks) but e.g. the SDSS filters are usually found in FAFLTNM. This PR doesn't do anything about that as I'm unsure on how you'd want to handle that properly.

mommermi commented 4 years ago

Thanks, let's leave this as is for now. If people run into the filter wheel issue, they can change the header keyword manually and update the filter translation dictionary.