mommermi / photometrypipeline

automated photometry pipeline for small to medium-sized observatories
GNU General Public License v3.0
62 stars 26 forks source link

Correct disp format in catalog.py #50

Closed Siltala closed 4 years ago

Siltala commented 4 years ago

This fixes bug #45 by using valid values for disp_dic in catalog.py.

I think that these values have always been invalid, but astropy has not validated them before release 4.0.1 (see https://github.com/astropy/astropy/pull/9978 ) so it hasn't raised any errors in the past and we've been feeding 'garbage' values into it until now. Considering that things have worked in the past even with invalid values here, maybe it's not actually too important..?

I don't know if the format in this commit makes much sense (it probably doesn't?) - I more or less arbitrarily copied it from the disp format used for OBSDATE. Still, astropy accepts it and thus it fixes the crash.

mommermi commented 4 years ago

Thanks, @Siltala!