add colr atom to existing mp4

momo0853 / mp4v2

mp4v2 for android

Other

19 stars 20 forks source link

add colr atom to existing mp4 #3

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

http://developer.apple.com/quicktime/icefloe/dispatch019.html#colr has details 
on the colr 
specification. it would be helpful to have be able to write this atom to an 
existing MP4 file.

Original issue reported on code.google.com by refulgentis@gmail.com on 2 Dec 2008 at 4:33

GoogleCodeExporter commented 8 years ago

Original comment by Kona8l...@gmail.com on 3 Dec 2008 at 12:02

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

r147 adds support to mp4track tool to manipulate COLR.
Example usage would be:

# list colr-boxes, if any
mp4track --colr-list test.m4v

# remove colr-box from all appropriate tracks
mp4track --colr-remove test.m4v

# remove colr-box from track-id=1
mp4track --colr-remove --track-id=1 test.m4v

# add colr-box of default type to tid=1
mp4track --colr-add --track-id=1 test.m4v

# add colr-box of same parameters which HB uses for HD content
mp4track --colr-add --track-id=1 --colr-parm-hd test.m4v

# add colr-box specifying all 3 indexes manually
mp4track --colr-add --track-id=1 --colr-parms=1,2,3 test.m4v

Original comment by Kona8l...@gmail.com on 11 Dec 2008 at 2:03

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

thanks, this works great!

Original comment by refulgentis@gmail.com on 11 Dec 2008 at 1:40

GoogleCodeExporter commented 8 years ago

the values for colr-parm-hd and colr-parm-sd are switched (SD should be 616, HD 
should be 111, see 
http://forum.handbrake.fr/viewtopic.php?f=4&t=6352&p=41489&hilit=colr#p36397). 
Attached is a patch 
against r150 to fix this. 

Tested and works as expected now, only part I was unsure about was if the reset 
function should be patched to 
have 616 instead of 111 as well, and I assume the reset function errs on the 
side of assuming SD material, so I 
did change it.

Original comment by refulgentis@gmail.com on 12 Dec 2008 at 12:46

Attachments:

fix_colr_hdsd.diff

GoogleCodeExporter commented 8 years ago

patch applied in r155... that is unless i borked something again as r155 was 
rather large.

Original comment by Kona8l...@gmail.com on 12 Dec 2008 at 8:34

GoogleCodeExporter commented 8 years ago

Original comment by Kona8l...@gmail.com on 18 Dec 2008 at 12:25

Changed state: Completed