search

momocow / semantic-release-gitmoji

✨🐛💥 A semantic-release plugin for gitmojis. Different from conventional changelog, Gitmoji commits are used to determine a release type and generate release notes.
MIT License
90 stars 20 forks source link

🐛 allow commits with reserved regex characters #85

Closed djcrabhat closed 2 months ago

djcrabhat commented 9 months ago

Closes #76

djcrabhat commented 2 months ago

Sorry to poke @momocow , but I see you releasing this repo again. Mind taking a look at this PR?

momocow commented 2 months ago

Sorry to poke @momocow , but I see you releasing this repo again. Mind taking a look at this PR?

Sure, let me see!

momocow commented 2 months ago

I think the main issue in #76 is that emoji-regex mis-recognizes the character, *, as an emoji. As a result, the solution should be fixing the emoji recognition instead of escaping regex characters.

Changing the import statement from require('emoji-regex/text') to require('emoji-regex') should fix the issue. BTW, there is no emoji-regex/text exported in the newer version of package emoji-regex anyway.

I'll reject this PR as it's not an ideal solution to #76 and file another one to fix it.

Thanks for providing an solution at first hand and poking me. 😉

djcrabhat commented 2 months ago

Thanks for providing an solution at first hand and poking me. 😉

Oh my pleasure and thanks for the deeper, truer fix. I'm a huge fan of your project, it has revolutionized git commit aesthetics and release process for my team ❤️