momocow / webpack-userscript

A Webpack plugin for userscript projects. 🙈
https://cow.moe/webpack-userscript/
MIT License
200 stars 21 forks source link

i18n @name does not work #102

Closed ilyhalight closed 1 year ago

ilyhalight commented 1 year ago

Hi, I was rewriting the headers in the updated i18n (webpack-userscript 3.2.1) and noticed that when specifying a localized "name", it is not saved during the build.

webpack.config.js settings:

    new UserscriptPlugin({
      headers: async () => {
        const headerPath = path.resolve(__dirname, 'src', 'headers.json');
        const header = JSON.parse(fs.readFileSync(headerPath).toString());

        let version = header.version;
        if (dev) {
          header["version"] = `${version}-build.[buildNo]`;
        }

        return header;
      },
      i18n: {
        // headers provider
        'en-US': {
          name: 'test123',
          description: 'test 123',
        },
        'ru': {
          name: 'name ru',
          description: 'test 123',
        },
      },
      proxyScript: {
        filename: "[basename].proxy.user.js",
        baseURL: "http://webpack.localhost:11944/",
      },
      strict: true,
    }),

Builded userscript meta:

// ==UserScript==
// @name LZT Upgrade
// @description Бесплатное расширение для Lolzteam с множеством полезных функций
// @description:en-US test 123
// @description:ru test 123
// @version 1.2.0
// @author Toil
// @supportURL https://github.com/ilyhalight/lzt-upgrade/issues
// @match *://*.lolz.guru/*
// @match *://*.lolz.live/*
// @match *://*.zelenka.guru/*
// @match *://*.lzt.market/*
// @match *://*.lolz.market/*
// @connect lztupgrade.toiloff.ru
// @connect greasyfork.org
// @downloadURL https://github.com/ilyhalight/lzt-upgrade/raw/master/dist/lzt-upgrade.user.js
// @grant GM_xmlhttpRequest
// @grant GM_info
// @homepageURL https://github.com/ilyhalight/lzt-upgrade
// @icon https://cdn.jsdelivr.net/gh/lzt-upgrade/lzt-upgrade@latest/src/images/logo-mini.png
// @namespace lztupgrade
// @require https://cdn.jsdelivr.net/npm/jquery@1.12.4/dist/jquery.min.js
// @updateURL https://github.com/ilyhalight/lzt-upgrade/raw/master/dist/lzt-upgrade.user.js
// ==/UserScript==
momocow commented 1 year ago

You're right. Thanks for reporting!

inazuma-bot commented 1 year ago

:tada: This issue has been resolved in version 3.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: