momocus / sakazuki

自宅の酒を管理するアプリケーション
https://sakazuki.fly.dev/
MIT License
13 stars 4 forks source link

Ruby 3.3.3 #727

Open yonta opened 3 weeks ago

yonta commented 3 weeks ago

もうRuby 3.3.3が出ている!

github-actions[bot] commented 3 weeks ago

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
meta.json app/assets/builds/application.js 1.01 MB 🆕 Added
Largest paths These visualization shows top 20 largest paths in the bundle. ## Meta file: meta.json, Out file: app/assets/builds/application.js | Path | Size | |------|-------| | node_modules/chart.js/dist | ${{\color{Goldenrod}{ ██████▊ }}}$ 27.4%, 273.88 KB | | app/javascript/completion | ${{\color{Goldenrod}{ ████▎ }}}$ 17.1%, 170.67 KB | | node_modules/@hotwired/turbo | ${{\color{Goldenrod}{ ███▎ }}}$ 13.2%, 131.96 KB | | node_modules/bootstrap/dist | ${{\color{Goldenrod}{ ███▏ }}}$ 12.5%, 124.34 KB | | node_modules/simplelightbox/dist | ${{\color{Goldenrod}{ ██▏ }}}$ 8.8%, 87.73 KB | | node_modules/@hotwired/stimulus | ${{\color{Goldenrod}{ ██ }}}$ 8.4%, 84.29 KB | | node_modules/@popperjs/core | ${{\color{Goldenrod}{ █▍ }}}$ 5.6%, 55.66 KB | | node_modules/@rails/actioncable | ${{\color{Goldenrod}{ ▌ }}}$ 2.0%, 19.51 KB | | node_modules/rater-js/index.js | ${{\color{Goldenrod}{ ▍ }}}$ 1.6%, 16.42 KB | | node_modules/@kurkle/color | ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 13.37 KB | | app/javascript/taste_graph | ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 7.56 KB | | app/javascript/controllers | ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 6.63 KB | | node_modules/@hotwired/turbo-rails | ${{\color{Goldenrod}{ }}}$ 0.4%, 3.82 KB | | node_modules/ts-deepmerge/esm | ${{\color{Goldenrod}{ }}}$ 0.2%, 1.69 KB | | node_modules/just-zip-it/index.mjs | ${{\color{Goldenrod}{ }}}$ 0.1%, 785 B | | node_modules/chart.js/helpers | ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B | | app/javascript/application.js | ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B |
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.
yonta commented 3 weeks ago

ん-?? bunlde installがActionsのときだけ失敗している

yonta commented 3 weeks ago

3.3.3で同じ問題に遭遇している人がいるようだ。 net-popかRuby本体か、メンテナが調査中。

https://github.com/ruby/net-pop/issues/26

yonta commented 2 weeks ago

Ruby側でパッチが入った。3.3.4で治るのかな

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.57%. Comparing base (37fe2c8) to head (7cebdfa). Report is 28 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #727 +/- ## ======================================= Coverage 96.57% 96.57% ======================================= Files 17 17 Lines 321 321 ======================================= Hits 310 310 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yonta commented 2 weeks ago

これで治るってあるけど、これいれるかどうするかは悩むわね。 現状、コミットに入れてみたら、やはりCIは通るようになった。

# Needed until Ruby 3.3.4 is released https://github.com/ruby/ruby/pull/11006
gem 'net-pop', github: 'ruby/net-pop'
yonta commented 6 days ago

Ruby3.3.4まで待つことにしよう。 Railsのバージョンアップは先にやってしまおう。