momocus / sakazuki

自宅の酒を管理するアプリケーション
https://sakazuki.fly.dev/
MIT License
13 stars 4 forks source link

esbuild-bundle-analyzerが正しくファイルを認識するようにした #739

Open yonta opened 2 weeks ago

yonta commented 2 weeks ago

fix #736

やったこと

yonta commented 2 weeks ago

PR #725 (CIの修正PR)を受け入れたあとにrebaseする

yonta commented 2 weeks ago

no base analysis foundとな…

image

Error: no matching workflow run found with any artifacts?
yonta commented 2 weeks ago

他のPRでAddedになってたときのActions見ると、なんかエラーでてるな。

https://github.com/momocus/sakazuki/actions/runs/9561872704 https://github.com/momocus/sakazuki/actions/runs/9561872704/job/26357032994

image

...
▶Run exoego/esbuild-bundle-analyzer@v1
▶Run dawidd6/action-download-artifact@v3
==> Repository: momocus/sakazuki
==> Artifact name: 
==> Local path: .analyzer/base
==> Workflow name: 995021[10](https://github.com/momocus/sakazuki/actions/runs/9561872704/job/26357032994#step:6:11)
==> Workflow conclusion: success
==> Branch: main
==> Allow forks: true
Error: no matching workflow run found with any artifacts?
Run node /home/runner/work/_actions/exoego/esbuild-bundle-analyzer/v1/dist/index.mjs
Wrote /home/runner/work/sakazuki/sakazuki/.analyzer/bundle_analysis.json {
  'meta.json -> app/assets/builds/application.js': {
    bytes: 1007464,
    metafile: 'meta.json',
    outfile: 'app/assets/builds/application.js'
  }
}
▶Run node /home/runner/work/_actions/exoego/esbuild-bundle-analyzer/v1/dist/index.mjs
...
yonta commented 2 weeks ago

このPRで起動したActionsではエラーでてない。

github-actions[bot] commented 6 days ago

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖 This PR introduced no changes to the esbuild bundle! 🙌

yonta commented 6 days ago

rebase後もやはりのーあーてぃふぁくとエラーは出てる。 つまり、ベースとなるmainブランチの解析結果がないってことか。

yonta commented 6 days ago

そもそもmainブランチの内容を保存しておかないといけないのでは。 つまりmainへのpushでこのアクションを起動するのを削除してるのが悪い気がしてきた。 mainへのpush時にアクション起動しないと、ベースブランチの解析結果(アーティファクト)が保存されないじゃん。

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.57%. Comparing base (37fe2c8) to head (760591b). Report is 32 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #739 +/- ## ======================================= Coverage 96.57% 96.57% ======================================= Files 17 17 Lines 321 321 ======================================= Hits 310 310 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.