momodalo / rubyripper

Automatically exported from code.google.com/p/rubyripper
3 stars 2 forks source link

Rubyripper doesn't parse strings retrieved from freedb correct #64

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
What is the expected output? What do you see instead?

There are errors in the routine for parsing the disc information retrieved 
from freedb.
This error can be re-produced by modifying rr_lib.rb cd_vars, and changing 
the line

-------------------
@socket.puts("cddb read #{@category} #{@discid}")
-------------------

to 

-------------------
@socket.puts("cddb read rock a4114c0c")
-------------------

This will get information about a Bob Dylan bootleg. After adding 

-------------------
puts(@raw_response)
-------------------

to the beginning of cd_vars, the following is printed on the screen (using 
rrip_cli):

--------------------------------------------------
DISCID=a4114c0c
DTITLE=Bob Dylan / A Knife A Fork A Bottle & A Cork (D2) Toledo 1998-0
DTITLE=2-15
DYEAR=1998
DGENRE=Rock
TTITLE0=It Ain't Me, Babe
TTITLE1=Love Sick
TTITLE2=Rainy Day Women #12 & 35
TTITLE3=Not Dark Yet (MSG/The Theater 98-01-16)
TTITLE4=Cold Irons Bound (MSG/The Theater 98-01-16)
TTITLE5=Tonight I'll Be Staying Here With You (Atlantic City 98-01-31)
TTITLE6=Just Like A Woman (Atlantic City, NJ 1998-01-31)
TTITLE7=Lonesome Death Of Hattie Carroll (MSG 98-01-17)
TTITLE8=Born In Time (Newark, NJ 98-02-01)
TTITLE9=Just Like Tom Thumb's Blues (Newark, NJ 98-02-01)
TTITLE10=My Back Pages (New London, CT 98-01-13)
TTITLE11=A Hard Rain's A Gonna Fall (MSG/The Theater 98-01-20)
--------------------------------------------------

but when the information about the record is printed from rrip_cli, this 
is displayed:

--------------------------------------------------
1) Artist : 2-15
2) Album :
3) Genre : Rock
4) Year : 1998
5) Track 1 : It Ain't Me, Babe
6) Track 2 : Love Sick
7) Track 3 : Rainy Day Women #12 & 35
8) Track 4 : Not Dark Yet (MSG
9) Track 5 : Cold Irons Bound (MSG
10) Track 6 : Tonight I'll Be Staying Here With You (Atlantic City 98-01-
31)
11) Track 7 : Just Like A Woman (Atlantic City, NJ 1998-01-31)
12) Track 8 : Lonesome Death Of Hattie Carroll (MSG 98-01-17)
13) Track 9 : Born In Time (Newark, NJ 98-02-01)
14) Track 10 : Just Like Tom Thumb's Blues (Newark, NJ 98-02-01)
15) Track 11 : My Back Pages (New London, CT 98-01-13)
16) Track 12 : A Hard Rain's A Gonna Fall (MSG
--------------------------------------------------

Now take a look at track 4. The original name was 

Not Dark Yet (MSG/The Theater 98-01-16)

but now it is changed to 

Not Dark Yet (MSG

I guess the regexp in cd_vars need some tweaking

What version of rubyripper are you using? On what operating system? Are 
you using the gtk2 or the commandline interface?

On Linux (Kubuntu). I use the 0.3 release, but I downloaded the latest 
source and it look untouched

Please provide any additional information below.

Original issue reported on code.google.com by crazysw...@gmail.com on 11 Mar 2007 at 1:37

GoogleCodeExporter commented 8 years ago
Thanks for reporting. Lately I've messed a bit around these variables due to 
adding 
variable artist support, so problems where to be expected. I'll see what I can 
do.

Original comment by rubyripp...@gmail.com on 11 Mar 2007 at 1:50

GoogleCodeExporter commented 8 years ago
I very much doubt that the latest svn does the same thing. I have quite 
recently 
improved the cleaning of 'weird' characters like '/', even after the beta-0.4 
release. I consider this closed as I can't reproduce it.

The artist + album naming is also fixed with latest commit (see issue 65).

Original comment by rubyripp...@gmail.com on 11 Mar 2007 at 3:36