Can't open unicode/multibyte file path

momodalo / vimtouch

vimtouch

Apache License 2.0

350 stars 71 forks source link

Can't open unicode/multibyte file path #1

Closed momodalo closed 11 years ago

momodalo commented 12 years ago

From google play comments, "if path to file contained cyrilic, file doesn't open."

rtfb commented 11 years ago

Hmm... Can't reproduce. Tried opening (via FileDialog) and editing+writing '/sdcard/хз/lietuviškai.txt' (both Russian and Lithuanian letters in path) on my Nexus One w/ Cyanogen 7.2. Also tried a simple ':w /sdcard/žąsinas.txt' on TF101 with original firmware. Both worked fine.

momodalo commented 11 years ago

I use ES File Explorer to open a file "/sdcard/Download/2 我.txt" and it failed. Is it possible that native open can't handle the multiple-byte filename?

rtfb commented 11 years ago

Ah, got it. Reproed and fixed. I'll clean it up and push soon.

momodalo commented 11 years ago

Fixed by rtfb

https://github.com/momodalo/vimtouch/commit/31cdc9e97078cd6b79da785837e4cbb577748c69