Compilation issues

[mvdan]

Hello momodalo,

I was trying to update your app on F-Droid from 2.3 to 2.6, and I came across a few issues:

• No AndroidManifest.xml. It is fine if you want to move them at build time, but we use them to check for updates and check for source code integrity (correct package id, etc). Could you please supply a base AndroidManifest.xml file with the basic info? (I know you put the version data in project.properties, but that's just your format and we really can't adapt to every single specific case). We can work without an update check for your app, but then it might be some time until we notice there had been an update for months (like it is now with 2.3 -> 2.6).
• You request for ANDROID_SDK_HOME and ANDROID_NDK_ROOT to be declared to run your script. Which is fine, but I'd rather use ANDROID_HOME for the SDK and ANDROID_NDK for the NDK. These are the standards and most systems already have them declared by default.
• Your README says that the script runs ndk-build, but it doesn't seem to. Either the script or the docs need updating.
• The build itself fails on NDK r9:

Running ndk-build in build/net.momodalo.app.vimtouch/
jni/fakegpm.c: In function 'Gpm_GetEvent':
jni/fakegpm.c:122:13: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors

Thank you for your time!

Regards.

[rtfb]

• The README is correct, it does call ndk-build, but indirectly. It calls ./run buildnative, which in turn calls ndk-build.
• Fixed the build error with https://github.com/momodalo/vimtouch/pull/62. Thanks for spotting this!

[mvdan]

Hello @rtfb,

You're correct about the README, I totally missed that one.

Thanks for fixing the build with r9!

My two first points still stand, although they are not critical.

[rtfb]

I can also comment some more on bullet point two, since both variables were intriduced by me. Neither of them is required per se. ANDROID_SDK_HOME is only used by a helper script that prepares a fresh system with prerequisites, which implies that the user is unlikely to have ANDROID_HOME either. After the system/workdir has been prepared (or if one chooses to prepare by other means), it's no longer needed.

ANDROID_NDK_ROOT is only needed if my heuristics code fails to detect NDK, which it would be nice to have feedback on -- how often people have to use it.

That said, I don't have problems with renaming either of these, but I'll leave the call to @momodalo :-)

[mvdan]

I want to be able to build the next vimtouch release on F-Droid without patching these things, so I opened a pull request.

[mvdan]

The variables ANDROID_SDK_HOME and ANDROID_NDK_ROOT were changed, which is not crucial but IMHO recommended since they are the default variable names. In fact they are already defined if the user installs the sdk and ndk via a package system like apt, yum, etc.