mon / 0x40-web

Pretty images and colours
http://0x40.mon.im/
MIT License
390 stars 38 forks source link

Animation sometimes isn't correct when using an animaition with beatsPerAnim and a song without charsPerBeat #38

Closed kepstin closed 3 years ago

kepstin commented 6 years ago

To see this happen, open e.g. the "Illya Dance" respack from https://portal.0x40.ga/pack/22 along with any respack that contains songs without charsPerBeat.

If you set the image to "Miyu Edelfelt & Illyasviel von Einzbern" and then change the song from Popcorn Funk to another song, the animation will stop. Some actions (switching tabs/windows?) might restart it, but the speed will be inconsistent - extremely fast sometimes.

I'd expect the animation to switch to the speed defined by the frame durations.

mon commented 3 years ago

I believe this is fixed in v3.9, please re-open the issue if I missed any edge cases.