mon / 0x40-web

Pretty images and colours
http://0x40.mon.im/
MIT License
388 stars 38 forks source link

"mute" works incorrectly #46

Closed howdiditcometothis closed 3 years ago

howdiditcometothis commented 3 years ago

On Vivaldi and Chrome, when I click the "vol" to mute the sound, it mutes the sound but the gui doesn't change unless I click again. On this second click, it unmutes but the gui changes to the "muted" state.

Also sometimes it seems to stop playback after finishing a song instead of looping or changing songs.

mon commented 3 years ago

That's concerning, I hope chromium hasn't changed anything to do with their audio model. Does the console provide any hints in error messages? This one's a bit tricky to debug from here.

howdiditcometothis commented 3 years ago

Checking console I've got one "red" error: "Failed to load resource: net::ERR_BLOCKED_BY_CLIENT HwU4Afx3ZsFv3HCMpwtQftaMMBI.js:1" as the first console entry

and one yellow warning: "DevTools failed to load SourceMap: Could not load content for https://0x40.mon.im/css/hues-min.css.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE"

mon commented 3 years ago

Both of those are fine, one is cloudflare's analytics being blocked, one is a sourcemap I didn't upload.

Is it specific songs? Repeatable? If you then manually change song does it change?

howdiditcometothis commented 3 years ago

Sorry for the delay. I've done a little testing: Autosong is on and set to 2 loops for both checks.

test performed on a site hosted on my own locally: Played the kanye song normally, switched to a different song with autosong, clicked mute, audio muted but ui didn't change, moved slider and audio unmutes (ui is still in unmuted state), let it play 2 loops and autosong changes song, audio mutes and ui goes to mute ui with () and at bottom of bar, clicking mute unmutes audio but ui still shows muted, autosong changes song and ui changes to "unmuted" state (both audio and ui are "unmuted"), dragging slider to 0 works normally and doesn't unmute after autosong changes.

On your site: Clicking mute will mute audio but ui is unchanged. Moving slider will unmute audio, ui is still unmuted. Changing songs manually or with auto song, the next song will be muted on play, with unmuted ui. (edit) another click of the button changes the ui state to mute and audio is still muted.

Doesn't seem to depend on the song or whether it's autosong or manual

mon commented 3 years ago

I believe this is now fixed in v3.9, feel free to re-open if I missed an edge case.