First song can't be from querried packs.

mon / 0x40-web

Pretty images and colours

http://0x40.mon.im/

MIT License

388 stars 38 forks source link

First song can't be from querried packs. #55

Open Ondrej-Douda opened 2 years ago

Ondrej-Douda commented 2 years ago

When external respack is loaded using URL querry, first song can't be selected from this respack... Example: https://0x40.mon.im/montegral.html?autoSong=off&packs=mon.zip&skipPreloader=off&song=lobster_loop

This will load selected respack, but use first song from default respack...

mon commented 2 years ago

Ah - the search for songs is based on the song name only, so if you provide song=LÅT it works fine.

There are some solutions here, such as just using the song name, or extending the search to also use the artist name and the filename, what are your thoughts?

Ondrej-Douda commented 2 years ago

Oh, so it searches by title, not song name, haven't thought about that... Using title is fine for me, but might be extended to use also filename (mentioned usecase)...

Some additional thoughts (might exist, but missed them): (Would be nice to be able to)

reference remote/external respacks using URL.
filter/deselect/forbid some respacks' resources (images/songs).
hide UI.
remove/delete already imported respacks.
reconstruct/generate URL with current settings (setup using UI, share by copy/paste).
add/append additional packsURL.

And I want to thank you for maintaining this wonderful tool/app/page/platform...

mon commented 2 years ago

Here's my recommendation: If you can host external respacks, you can host your own hues! This solves

reference remote/external respacks using URL.
add/append additional packsURL
filter/deselect/forbid some respacks' resources (images/songs)
remove/delete already imported respacks.
- Just delete them
hide UI
- make a CSS rule: .hues-ui { display: none }

The one I can't easily solve at the moment: reconstruct/generate URL with current settings (setup using UI, share by copy/paste).

I like the idea, but it might take some time to implement as I am time-poor.

Ondrej-Douda commented 2 years ago

These thought were mostly about ability to tailor already hosted hues... Referencing external respacks would be for ability to load others work from different hues/sites... Then you could merge and choose from all the resource available on internet... Most of the "recomendations" are targeted for querring...

If you don't mind I'll fiddle with your code and possibly make some improving PRs...

mon commented 2 years ago

Seems reasonable enough - that's why the code is open-source, after all!