search

mon / 0x40-web

Pretty images and colours
http://0x40.mon.im/
MIT License
388 stars 38 forks source link

Only override loading button if respack unchanged #75

Closed mjsir911 closed 1 year ago

mjsir911 commented 1 year ago

If a respack is loaded then a different one is selected, the loading button still gets overridden on the new respack. This behaviour is slightly confusing and the PR fixes it :-)

The only point of confusion that might exist is if you select a different respack then re-select the one that is currently loading, it is labelled as already loaded. This is a minor confusion that exists anyways regardless of this PR but I stumbled onto it/exposed it a bit more.

mon commented 1 year ago

The real fix is to port the entire respack UI to svelte to sort out all these weird little state issues (loading many respacks at once is generally kinda awful). EG a loaded respack should transition to the full view, instead of having to click the separate entry in the list of loaded packs...

However, that's a massive effort, and I like that this fixes one of the small niggles. If you can fix the merge conflicts it's great to merge!

mjsir911 commented 1 year ago

@mon ping

mon commented 1 year ago

Huh, I don't think I got an email for the force push. Very odd. Thanks for the bump.