mon / BemaniPatcher

Web based DLL binary patcher
MIT License
211 stars 134 forks source link

Add "number" type & timing offsets for DDR A/A20 #223

Closed nchowning closed 2 years ago

nchowning commented 2 years ago

This PR creates a new patch type called "number". It allows users to put in a number (in decimal) for a value. These values are most likely going to always be 32 bit integers (4 bytes) but they can be more or less. This is especially useful for changing timing offsets in DDR. The min and max options are only enforced if using the up & down arrow buttons on the number input field. Later it might be a good idea to either telegraph the min/max values to the user better or enforce them in the applyPatch method.

I've also added timing offsets for all DDR A/A20 mixes. These values are:

Lastly, I added the ability for "union" patch types to have a tooltip set for the whole union - not just individual patch options inside of the union.

mon commented 2 years ago

The use of the 32 bit view will limit the max size to 32 bits, i think. Also, we may want to support big endian numbers in the future.

Let's cross that bridge when we get to it, this patch is awesome.

nchowning commented 2 years ago

The use of the 32 bit view will limit the max size to 32 bits, i think. Also, we may want to support big endian numbers in the future.

Let's cross that bridge when we get to it, this patch is awesome.

Oh that's true 🤦‍♂️ . Thanks!