mon / BemaniPatcher

Web based DLL binary patcher
MIT License
211 stars 134 forks source link

support dynamic patcher #224

Closed ichijyo-hotaru closed 2 years ago

ichijyo-hotaru commented 2 years ago

This PR is for a string or code in the entire file and replaces it if the offset is not known.

qma.html is just a sample. Since it is a BemaniPatcher, I'll erase it before merging.

mon commented 2 years ago

This is a decently complex patch - I might not be able to look at it until the weekend. Thanks for your patience!

mon commented 2 years ago

Ok! My thoughts:

DynamicStringPatch and DynamicHexadecimalPatch are very similar. I think I would prefer to have one DynamicPatch class that has mode=string or mode=hex. This is a little bit of work, so if you prefer not to do that, I can merge it anyway. 👌

Otherwise, I really like this patch set. I have been wanting to do dynamic patches for some time!

mon commented 2 years ago

Looks great! Thank you again